Static code analysis can find hundreds of opportunities in VBA code.
Rubberduck builds its own internal representation of the code, and then proceeds to analyze it. Each individual inspection can easily be disabled, or configured to issue inspection results at different severity levels ranging from Hint to Error.
Use the Inspection Results toolwindow to review Rubberduck’s findings, search, filter, regroup results by inspection, location, type, or severity. Each inspection result comes with a detailed description of what’s being flagged and why, so you can make an enlightened decision.
Unless configured otherwise, Rubberduck automatically runs inspections after the a parser/resolver cycle completes (regardless of whether the inspection results toolwindow is displayed or not).
For the best experience, it would be recommended to first try Rubberduck with an empty project, add a new module, and write, say, a loop that counts 1 to 10 and outputs to the debug pane - then to parse that and review the inspection results; carefully review the inspection settings, and consider disabling the inspections that irreconcilably clash with your preferences: use meaningful names alone can easily produce hundreds upon hundreds of results if you’re not that much into using vowels, or if you, say, prefix all your variable names; these inspections can be re-enabled anytime you’re ready!
These inspections look for a wide range of potential issues, from missing Option Explicit to undeclared or unused variables.
Warns about late-bound WorksheetFunction calls made against the extended interface of the Application object.
Default severity: Suggestion
An early-bound, equivalent function exists in the object returned by the Application.WorksheetFunction property; late-bound member calls will fail at run-time with error 438 if there is a typo (a typo fails to compile for an early-bound member call); given invalid inputs, these late-bound member calls return a Variant/Error value that cannot be coerced into another type. The equivalent early-bound member calls raise a more VB-idiomatic, trappable runtime error given the same invalid inputs: trying to compare or assign a Variant/Error to another data type will throw error 13 "type mismatch" at run-time. A Variant/Error value cannot be coerced into any other data type, be it for assignment or comparison.
This inspection will only run if the Excel library is referenced.
Locates arguments passed to functions or procedures for object parameters which the do not have a compatible declared type.
Default severity: Warning
The VBA compiler does not check whether different object types are compatible. Instead there is a runtime error whenever the types are incompatible.
Warns about parameters passed by value being assigned a new value in the body of a procedure.
Default severity: Warning
Debugging is easier if the procedure's initial state is preserved and accessible anywhere within its scope. Mutating the inputs destroys the initial state, and makes the intent ambiguous: if the calling code is meant to be able to access the modified values, then the parameter should be passed ByRef; the ByVal modifier might be a bug.
Warns about a variable that is assigned, and then re-assigned before the first assignment is read.
Default severity: Suggestion
The first assignment is likely redundant, since it is being overwritten by the second.
Indicates that the value of a hidden VB attribute is out of sync with the corresponding Rubberduck annotation comment.
Default severity: Warning
Keeping Rubberduck annotation comments in sync with the hidden VB attribute values, surfaces these hidden attributes in the VBE code panes; Rubberduck can rewrite the attributes to match the corresponding annotation comment.
Locates 'Const' declarations that are never referenced.
Default severity: Warning
Declarations that are never used should be removed.
Locates indexed default member calls for which the corresponding object does not have a suitable suitable default member.
Default severity: Warning
The VBA compiler does not check whether the necessary default member is present. Instead there is a runtime error whenever the runtime type fails to have the default member.
Identifies empty module member blocks.
Default severity: Warning
Methods containing no executable statements are misleading as they appear to be doing something which they actually don't. This might be the result of delaying the actual implementation for a later stage of development, and then forgetting all about that.
Locates instances of member calls made against the result of a Range.Find/FindNext/FindPrevious method, without prior validation.
Default severity: Warning
Range.Find methods return a Range object reference that refers to the cell containing the search string; this object reference will be Nothing if the search didn't turn up any results, and a member call against Nothing will raise run-time error 91.
This inspection will only run if the Excel library is referenced.
Locates public User-Defined Function procedures accidentally named after a cell reference.
Default severity: Warning
Another good reason to avoid numeric suffixes: if the function is meant to be used as a UDF in a cell formula, the worksheet cell by the same name takes precedence and gets the reference, and the function is never invoked.
This inspection will only run if the Excel library is referenced.
Warns when a user function's return value is discarded at all its call sites.
Default severity: Warning
A 'Function' procedure normally means its return value to be captured and consumed by the calling code. It's possible that not all call sites need the return value, but if the value is systematically discarded then this means the function is side-effecting, and thus should probably be a 'Sub' procedure instead.
Warns when a user function's return value is not used at a call site.
Default severity: Warning
A 'Function' procedure normally means its return value to be captured and consumed by the calling code.
Warns when a user function's return value is never used, at any of its call sites.
Default severity: Warning
A 'Function' procedure normally means its return value to be captured and consumed by the calling code. It's possible that not all call sites need the return value, but if the value is systematically discarded then this means the function is side-effecting, and thus should probably be a 'Sub' procedure instead.
Identifies class modules that define an interface with one or more members containing a concrete implementation.
Default severity: Suggestion
Interfaces provide an abstract, unified programmatic access to different objects; concrete implementations of their members should be in a separate module that 'Implements' the interface.
Highlights implicit ByRef modifiers in user code.
Default severity: Hint
In modern VB (VB.NET), the implicit modifier is ByVal, as it is in most other programming languages. Making the ByRef modifiers explicit can help surface potentially unexpected language defaults.
Locates unqualified Workbook.Worksheets/Sheets/Names member calls inside workbook document modules that implicitly refer to the containing workbook.
Default severity: Warning
Implicit references inside a workbook document module can be mistakes for implicit references to the active workbook, which is the behavior in all other modules By explicitly qualifying these member calls with Me, the ambiguity can be resolved.
This inspection will only run if the Excel library is referenced.
Locates unqualified Worksheet.Range/Cells/Columns/Rows member calls inside worksheet modules that implicitly refer to the containing sheet.
Default severity: Warning
Implicit references inside a worksheet document module can be mistakes for implicit references to the active worksheet, which is the behavior in all other places. By explicitly qualifying these member calls with Me, the ambiguity can be resolved.
This inspection will only run if the Excel library is referenced.
Identifies the use of non-indexed default member accesses.
Default severity: Warning
Default member accesses hide away the actually called member. This is especially misleading if there is no indication in the expression that such a call is made and can cause errors in which a member was forgotten to be called to go unnoticed.
Warns about constants that don't have an explicitly defined type.
Default severity: Warning
All constants have a declared type, whether a type is specified or not. The implicit type is determined by the compiler based on the value, which is not always the expected type.
Identifies the use of indexed default member accesses that require a recursive default member resolution.
Default severity: Warning
Default member accesses hide away the actually called member. This is especially misleading if there is no indication in the expression that such a call is made and the final default member is not on the interface of the object itself. In particular, this can cause errors in which a member was forgotten to be called to go unnoticed.